Repository navigation
refactor(engine): simplify for doing our own OLAP partitioning - #5376
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
 [Medium impact] The PR appears safe to merge; no actionable issues were found. SummarySimplifies OLAP partition maintenance and separates historical metric fallback from partition ownership.
No actionable issues were found. Runtime tests were not run. Reviews (1) · Last reviewed commit: "fix: comment" · Reviewed by Greptile |
mrkaye97
commented
Oct 29, 2026
Comment on lines
+187
to
+209
| SELECT | ||
| SPLIT_PART(entry, ':', 1) AS parent_table, | ||
| SPLIT_PART(entry, ':', 2) AS partition_frequency | ||
| FROM UNNEST(ARRAY[ | ||
| 'v1_tasks_olap:daily', | ||
| 'v1_dags_olap:daily', | ||
| 'v1_runs_olap:daily', | ||
| 'v1_events_olap:daily', | ||
| 'v1_event_to_run_olap:daily', | ||
| 'v1_event_lookup_table_olap:weekly', | ||
| 'v1_incoming_webhook_validation_failures_olap:daily', | ||
| 'v1_cel_evaluation_failures_olap:daily', | ||
| 'v1_payloads_olap:daily', | ||
| 'v1_otel_trace_olap:daily', | ||
| 'v1_otel_trace_lookup_olap:daily', | ||
| 'v1_task_events_olap:daily', | ||
| 'v1_dag_to_task_olap:daily', | ||
| 'v1_lookup_table_olap:monthly', | ||
| 'v1_statuses_olap:monthly', | ||
| 'v1_agg_task_statuses_minute_olap:daily', | ||
| 'v1_agg_task_events_minute_olap:daily', | ||
| 'v1_agg_events_minute_olap:daily' | ||
| ]::TEXT[]) AS entry |
Contributor
Author
There was a problem hiding this comment.
reworked this a bit - IMO this is a lot easier to read / understand than the old way
grutt
approved these changes
Oct 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplifying some OSS code to go along with doing our own OLAP table partitioning
Type of change
Checklist
Changes have been:
🤖 AI Disclosure
No AI