Repository navigation
Conversation
Propagate registration RPC errors and close the health server when listener startup fails. Record unexpected listener termination so Worker.start raises after graceful cleanup instead of exiting successfully. Add regression coverage, bump the Python SDK to 1.43.1, and sync the changelog documentation. Refs hatchet-dev#5280
|
@satya-sudo is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThe Python SDK now reports worker registration failures and unexpected listener exits instead of returning success.
Review was based on code inspection; tests were not run. Reviews (3) · Last reviewed commit: "Merge branch 'main' into fix/python-work..." · Reviewed by Greptile |
mrkaye97
self-requested a review
October 28, 2026 13:01
mrkaye97
approved these changes
Oct 29, 2026
mrkaye97
left a comment
Contributor
There was a problem hiding this comment.
this looks good to me, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a Python worker's registration RPC failed, listener cleanup could raise an
AttributeErrorfor an uninitialized task. The parent then shut down with exit code 0, leaving the worker stopped under an on-failure restart policy.Initialize the optional
blocked_main_looptask, propagate registration errors, and close the health server if listener startup fails. Record unexpected listener termination in the parent soWorker.start()raises after graceful cleanup instead of reporting success. Intentional task-limit shutdown continues to exit successfully.Adds regression coverage, bumps the Python SDK to 1.43.3, and updates the SDK and generated documentation changelogs.
Closes #5280
Type of change
Checklist
Testing
python -m pytest tests/unit/test_worker_registration_failure.py tests/unit/test_shutdown_ordering.py -q -o log_cli=false— 18 passed.git diff --checkpassed.🤖 AI Disclosure