Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Medium impact] The Python SDK API change reaches callers that reset durable-stream topics. The repository’s release requirement must be satisfied before merging the TypeScript example change. SummaryAdds a durable streams guide with publishing, cursor resume, reset, and retry examples.
Reviews (6) · Last reviewed commit: "update docs etc" · Reviewed by Greptile |
| export async function resetToCursor() { | ||
| // > Reset to a cursor | ||
| let cursor: string | undefined; |
There was a problem hiding this comment.
TypeScript release records are missing
The new resetToCursor example changes sdks/typescript/src/**, but this PR includes no TypeScript SDK version bump or changelog entry. AGENTS.md requires both for changes under that directory, including examples. Add them before merging.
Context Used: AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
they're just examples, not changes to the actual SDK
There was a problem hiding this comment.
You're right that this only adds an example and doesn't change the SDK's runtime behavior or API. I flagged it because the repo's AGENTS.md currently applies the version-bump/changelog requirement to all changes under sdks/typescript/src/**, and this example is inside that path. If examples are meant to be exempt, that instruction should be narrowed; as written, it includes them.
Description
Adds documentation for the durable streams feature.
Fixes # (issue)
Type of change
Checklist
Changes have been:
🤖 AI Disclosure