Integrate hclog - #155
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Eric Gourlaouen seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
Is there any way to move this forward? |
|
You can use logger := hclog.New(nil)
logger.StandardLogger(&hclog.StandardLoggerOptions{InferLevels: true})This PR seems to have many merge conflicts, so it would probably be easier to start from scratch. If someone were to do that, it might be preferable to accept an interface that can be satisfied by |
With this pull request,
memberlistuseshclog.Loggeras logging interface.Here are a few other changes that this commit integrates:
ConfigandNetTransportConfigare changed, and now take directly thehclog.Loggerobject. If no object is passed,newMemberlistuseshclog.Default().fromAddressandfromConnare now methods of a struct that embedshclog.Logger.hclogand added them with the"err"field name.