Skip to content

Fix to query all nodes on multiple responses #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patopesto wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix to query all nodes on multiple responses #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e37101a
fix to query all new nodes on multiple PTR responses
patopesto Oct 28, 2024
985e648
Merge branch 'main' into fix-ptr-responses
patopesto Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 28 additions & 19 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ type ServiceEntry struct {

Addr net.IP // @Deprecated

hasTXT bool
sent bool
hasTXT bool
sent bool
nodeQueried bool
}

// complete is used to check if we have all the info we need
Expand Down Expand Up @@ -373,23 +374,31 @@ func (c *client) query(params *QueryParam) error {
continue
}

// Check if this entry is complete
if inp.complete() {
if inp.sent {
continue
}
inp.sent = true
select {
case params.Entries <- inp:
default:
}
} else {
// Fire off a node specific query
m := new(dns.Msg)
m.SetQuestion(inp.Name, dns.TypePTR)
m.RecursionDesired = false
if err := c.sendQuery(m); err != nil {
c.log.Printf("[ERR] mdns: Failed to query instance %s: %v", inp.Name, err)
// Check all new queries
for _, inp := range inprogress {
// Check if this entry is complete
if inp.complete() {
inp.nodeQueried = true
if inp.sent {
continue
}
inp.sent = true
select {
case params.Entries <- inp:
default:
}
} else {
if inp.nodeQueried {
continue
}
// Fire off a node specific query
inp.nodeQueried = true
m := new(dns.Msg)
m.SetQuestion(inp.Name, dns.TypePTR)
m.RecursionDesired = false
if err := c.sendQuery(m); err != nil {
c.log.Printf("[ERR] mdns: Failed to query instance %s: %v", inp.Name, err)
}
}
}
case <-finish:
Expand Down