chore: Bump helidon version to 4.5.0#864
Open
derektriley wants to merge 2 commits into
Open
Conversation
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
anthony-swirldslabs
previously approved these changes
Jun 22, 2026
alex-kuzmin-hg
previously approved these changes
Jun 22, 2026
alex-kuzmin-hg
left a comment
Contributor
There was a problem hiding this comment.
Looks OK. I'll run full SDPT after new BN tag
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request updates the Helidon dependency and makes necessary adjustments to the gRPC client stream implementation to support the new version. The changes ensure compatibility with Helidon 4.5.0 by updating constructor signatures and usages to include the new required
Http2ClientImplparameter.Dependency upgrade:
4.4.1to4.5.0inbuild.gradle.kts, preparing the project for the latest features and fixes.Code changes for Helidon 4.5.0 compatibility:
PbjGrpcClientStreamclass constructor to accept an additionalHttp2ClientImplparameter and updated its call to the superclass constructor accordingly.PbjGrpcClientStreaminPbjGrpcClient.javato pass the newHttp2ClientImplargument as required by the updated Helidon API.Http2ClientImplinPbjGrpcClientStream.javato support the new constructor parameter.Fixes:
BidiStreamingBuilderImpl.onComplete() calls incoming.onComplete() followed by super.onComplete(). The first call cascades
through the user's handler → response converter → SendToClientSubscriber.onComplete(), which sends a HEADERS+END_STREAM
trailer frame to the client. The super.onComplete() call then invokes SendToClientSubscriber.onComplete() a second time,
sending a duplicate trailer frame.
On the client side (Helidon 4.5.0), pushTrailers() detects the duplicate via inboundEndQueued and throws Http2Exception.
This propagates up to the connection read loop's exception handler, which calls buffer.fail() on the stream's
StreamBuffer. Because StreamBuffer.fail() causes all subsequent and currently-waiting poll() calls to throw immediately —
even if unread DATA frames are already queued — the client's reply-reading loop dies after consuming only 1 of 3
expected replies.
The fix makes SendToClientSubscriber.onComplete() idempotent with an AtomicBoolean guard. The framework's safety-net
behavior (calling replies.onComplete() via super.onComplete() in case the user's handler doesn't) is preserved for
handlers that don't call it themselves; duplicate calls from handlers that do are now no-ops.
Test code cleanup:
testCreatePbjGrpcClientStreamtest, as the stream ID behavior has changed or is no longer relevant.Related issue(s):
Fixes #863
Notes for reviewer:
Checklist