Use the consolidated PHP and JavaScript check workflows - #46
Open
jeremyfelt wants to merge 2 commits into
Open
Conversation
Replaces the single-purpose check workflows with the consolidated php-checks and js-checks workflows from happyprime/workflows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Plugin Check passedNo errors or warnings from |
- lint:js='eslint .' - lint:package scoped to the repository's own package.json - coding-standards=0.0.6 phpstan=1.12.34 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the single-purpose check workflows with the consolidated
php-checksandjs-checksworkflows from happyprime/workflows.Each consolidated workflow pays for checkout, language setup, and dependency install once instead of once per check, and runs every check it finds configured so a single push reports every problem at once.
What this changes here
.github/workflows/php-checks.ymland.github/workflows/js-checks.yml.phpcs.yml,phpstan.yml.phpcs.xml), PHPSTAN (phpstan.neon.dist).npm run lint), package.json lint (npm run lint:package).Checks running in CI here for the first time
These are configured in the repository but had no workflow, so this pull request is the first time they run. A failure below is a pre-existing issue this surfaces, not something this pull request introduces:
A check that is configured but cannot run (missing binary, missing
bin/install-wp-tests.sh, a config with no npm script) is skipped and reported in a pull request comment rather than failed.Once this is merged the two files move under sync management in
happyprime/projects.🤖 Generated with Claude Code