Skip to content

Rename to PublisherPhotography and PublisherIllustration - #5192

Merged
junyuanxue merged 1 commit into
mainfrom
11-05-rename_to_publisherphotography_and_publisherillustration
Nov 6, 2026
Merged

junyuanxue merged 1 commit into
mainfrom
11-05-rename_to_publisherphotography_and_publisherillustration

Conversation

@junyuanxue

@junyuanxue junyuanxue commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

What does this change?

Rename 'Publisher Photographer' to 'Publisher Photography', 'Publisher Illustrator' to 'Publisher Illustration', as these would be clearer to journalists

How should a reviewer test this change?

  • Update your local common.conf to include in usageRights.applicable list:
  "com.gu.mediaservice.model.PublisherPhotography",
  "com.gu.mediaservice.model.PublisherIllustration",  
  • You should see under metadata edit:
Screenshot 2026-11-05 at 18 12 05

Tested? Documented?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment
  • relevant documentation added or amended (if needed)

@junyuanxue junyuanxue added the feature Departmental tracking: work on a new feature label Nov 5, 2026
@junyuanxue
junyuanxue marked this pull request as ready for review November 5, 2026 18:12
@junyuanxue
junyuanxue requested a review from a team as a code owner November 5, 2026 18:12
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

@junyuanxue
junyuanxue force-pushed the 11-05-rename_to_publisherphotography_and_publisherillustration branch from a29750d to 72685a3 Compare November 5, 2026 18:47

@blishen blishen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it is worth LGTM

@gu-prout

gu-prout Bot commented Nov 6, 2026

Copy link
Copy Markdown

Seen on auth, usage, image-loader, leases, collections, kahuna (merged by @junyuanxue 11 minutes and 28 seconds ago) Please check your changes!

@gu-prout

gu-prout Bot commented Nov 6, 2026

Copy link
Copy Markdown

Seen on metadata-editor, thrall, cropper (merged by @junyuanxue 11 minutes and 37 seconds ago) Please check your changes!

@gu-prout

gu-prout Bot commented Nov 6, 2026

Copy link
Copy Markdown

Seen on media-api (merged by @junyuanxue 11 minutes and 45 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants