fix(plugins): reject unknown filename directives - #281
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
Signed-off-by: nightcityblade <nightcityblade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<target>-onlydirectives and trailing tilde fencesWhy
KNOWN_DIRECTIVESwas defined but never consulted, so a typo such as~overwritwas silently carried into the VFS as an inert condition. Failing fast with the filename and bad token prevents broken plugin bundles from shipping while preserving the repository's supported target-only and fenced filename forms.Validation
npm --prefix src/rosettify-plugins test -- tests/unit/vfs/directives.test.ts --reporter=verbose— passedROSETTIFY_PLUGINS_LOG_LEVEL=warn npm --prefix src/rosettify-plugins test -- --reporter=minimal— 574 passednpm --prefix src/rosettify-plugins run typecheck— passednpm --prefix src/rosettify-plugins run build— passedROSETTIFY_PLUGINS_LOG_LEVEL=warn venv/bin/python scripts/pre_commit.py— passedChecklist
AI assistance was used to inspect the issue, implement the focused change, and run validation. I reviewed every changed line.
Closes #272