fix(cli): honor page size for filtered cleanup - #280
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
Signed-off-by: nightcityblade <nightcityblade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page_sizeto tag- and prefix-filtered cleanup queriesWhy
cleanup-dataset --tagsand--prefixsilently usedDocumentService's default limit of 1000 instead ofRAGFLOW_PAGE_SIZE. Deployments configured above that default could therefore under-delete matching documents without warning. The unfiltered branch already honors the configured page size; this makes all three paths consistent.Validation
PYTHONPATH=src/rosetta-cli venv/bin/python -m pytest -q src/rosetta-cli/tests/test_cleanup_command.py src/rosetta-cli/tests/test_command_auth_order.py— 5 passedPYTHONPATH=src/rosetta-cli venv/bin/python -m pytest -q src/rosetta-cli/tests— 39 passeduvx ruff check src/rosetta-cli/tests/test_cleanup_command.py— passeduvx ruff check --select E9,F63,F7,F82 src/rosetta-cli/rosetta_cli/commands/cleanup_command.py— passeduvx ruff format --check src/rosetta-cli/tests/test_cleanup_command.py— passedROSETTIFY_PLUGINS_LOG_LEVEL=warn venv/bin/python scripts/pre_commit.py— passedChecklist
AI assistance was used to inspect the issue, implement the focused change, and run validation. I reviewed every changed line.
Closes #267