Repository navigation
Add: separate TLS certificates for ingress server and agent control - #43
Merged
Merged
Conversation
pascalholthaus
force-pushed
the
pholthaus/ingress-agent
branch
from
October 5, 2026 07:29
61ad9c3 to
57e8a64
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Existing deployments may fail without a migration path, and the documented EC key requirement is not enforced.
Review effort: Lite
Findings: 1
What changed in this PR
Adds separate TLS certificate handling for the ingress server and agent-control endpoint.
Changes:
- Adds agent-control certificate options and configuration.
- Generates and loads separate certificate pairs.
- Updates CLI help and README documentation.
| File | Summary |
|---|---|
src/help.sh |
Documents certificate options; EC key requirement conflicts with current validation. |
src/global.sh |
Adds agent-control certificate variables. |
src/certs.sh |
Implements separate certificate handling; requires backward compatibility and EC key validation. |
src/args.sh |
Parses agent-control certificate arguments. |
README.md |
Documents the new certificate configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
pascalholthaus
marked this pull request as ready for review
October 5, 2026 08:56
greenbonebot
enabled auto-merge (squash)
October 5, 2026 09:01
pascalholthaus
force-pushed
the
pholthaus/ingress-agent
branch
from
October 5, 2026 09:07
37c3476 to
0de783a
Compare
pascalholthaus
disabled auto-merge
October 5, 2026 09:33
pascalholthaus
enabled auto-merge (squash)
October 5, 2026 09:33
henning
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add: Separate TLS certificates for ingress server and agent control
Why
CPB-993
References
CPB-993
Checklist