Repository navigation
Fix: free performance body before overwriting it - #1155
Open
mattmundell wants to merge 3 commits into
Open
mattmundell wants to merge 3 commits into
mattmundell wants to merge 3 commits into
Conversation
The body from http_scanner_send_request() leaked on every success.
The body from http_scanner_send_request() leaked on every error.
greenbonebot
enabled auto-merge (rebase)
October 22, 2026 12:04
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Free
response->bodywithg_freebefore overwriting it in both the successand error branches of
openvasd_get_performance()(openvasd/openvasd.c).Why
Both branches assigned a new string over the body returned by
http_scanner_send_request()without freeing it, so that allocation leaked onevery call, successful or not.
Testing
openvasd_get_performance_frees_body_on_success(openvasd-test): before thefix, LeakSanitizer reported a 16-byte direct leak allocated by
http_scanner_send_request(http_scanner/http_scanner.c:478); after, thecase passes with no leak report.
openvasd_get_performance_frees_body_on_error(openvasd-test): before thefix, LeakSanitizer reported a 35-byte direct leak allocated by
http_scanner_send_request(http_scanner/http_scanner.c:469); after, thecase passes with no leak report.