Repository navigation
Fix: reuse parsed performance JSON on error - #1154
Open
mattmundell wants to merge 2 commits into
Open
mattmundell wants to merge 2 commits into
mattmundell wants to merge 2 commits into
Conversation
The error path parsed the response body again, leaking the first cJSON tree.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
greenbonebot
enabled auto-merge (rebase)
October 22, 2026 10:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the second
cJSON_Parse (resp->body)on the non-200 path ofopenvasd_parsed_performance, reusing the parse taken before the status checkfor the error item.
Why
openvasd_parsed_performanceparsed the response body before the status checkand parsed it again on the non-200 path, overwriting the first cJSON tree and
leaking it and its children on every error response.
Testing
Before the change,
openvasd_parsed_performance_error_response_frees_parser(openvasd-test) leaked 160 bytes in 4 allocations from
openvasd_parsed_performance(openvasd/openvasd.c:195), a direct 64-byte cJSONtree plus its indirect children. After the change the same case passes with no
ASan or LeakSanitizer report.