Skip to content

Show a better error message if a test file is missing a descrption - #4731

Merged
kainino0x merged 1 commit into
gpuweb:mainfrom
greggman:tree-error
Nov 16, 2026
Merged

kainino0x merged 1 commit into
gpuweb:mainfrom
greggman:tree-error

Conversation

@greggman

Copy link
Copy Markdown
Member

It took me an embarrassingly long amount of time to figure out TypeError: Cannot read properties of undefined (reading 'trim') meant that I forgot to put a description at the top of the test file (vs a description for an individual test) 😅


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@github-actions

Copy link
Copy Markdown

Results for build job (at cf4857d):

 Test case/subcase counts did not change.

Comment thread src/common/internal/tree.ts Resolved
@kainino0x
kainino0x merged commit bbbace1 into gpuweb:main Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants