Skip to content

feat(security): application token refresh#986

Open
eternal-flame-AD wants to merge 4 commits into
masterfrom
sec-update-rekey
Open

feat(security): application token refresh#986
eternal-flame-AD wants to merge 4 commits into
masterfrom
sec-update-rekey

Conversation

@eternal-flame-AD

Copy link
Copy Markdown
Member

Fixes #985

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.34%. Comparing base (e33d576) to head (13ebe86).

Files with missing lines Patch % Lines
api/application.go 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #986      +/-   ##
==========================================
+ Coverage   74.33%   74.34%   +0.01%     
==========================================
  Files          66       66              
  Lines        3444     3461      +17     
==========================================
+ Hits         2560     2573      +13     
- Misses        686      688       +2     
- Partials      198      200       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread api/application_test.go Outdated
Comment thread ui/src/application/AppStore.ts Outdated
Comment thread ui/src/application/Applications.tsx Outdated
Comment thread ui/src/application/Applications.tsx Outdated
Comment thread ui/src/application/AddApplicationDialog.tsx Outdated
Comment thread ui/src/application/Applications.tsx Outdated
Comment thread api/application_test.go
}
}

func (s *ApplicationSuite) Test_UpdateApplicationSecurity_regenerateToken() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly off-topic: Can you add a small description of the breaking api changes from your previous PR to https://gotify.net/docs/migrate-to-3#api-changes ?

@jmattheis jmattheis mentioned this pull request Jun 30, 2026
14 tasks
@eternal-flame-AD eternal-flame-AD marked this pull request as ready for review June 30, 2026 12:31
@eternal-flame-AD eternal-flame-AD requested a review from a team as a code owner June 30, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Credential Management API

2 participants