Delay windows tests to make them less flaky - #1103
Open
kgaughan wants to merge 4 commits into
Open
Conversation
PR goss-org#1017 introduced support for service checks on Windows, but doing so had the unfortunate side effect that MSDTC (the service used in the test) is not guaranteed to be started soon enough after the job step for running the integration tests is able to run to guarantee that it'll work. Delaying for 2s should make this more reliable.
Open
This was referenced Aug 9, 2026
kgaughan
added a commit
to kgaughan/goss
that referenced
this pull request
Aug 9, 2026
Collaborator
Author
|
@cthiel42 It turns out that the addition of the Windows service check support has made the integration tests a bit flaky. Are you aware of any other services besides MSDTC that might start a little faster and more reliably? |
Contributor
|
@kgaughan The |
Collaborator
Author
|
Thanks! I'll give that a try when I'm back at my laptop. |
Collaborator
Author
|
It looks like that did the trick. |
kgaughan
added a commit
to kgaughan/goss
that referenced
this pull request
Aug 9, 2026
3 tasks
kgaughan
added a commit
to kgaughan/goss
that referenced
this pull request
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
PR #1017 introduced support for service checks on Windows, but doing so had the unfortunate side effect that MSDTC (the service used in the test) is not guaranteed to be started soon enough after the job step for running the integration tests is able to run to guarantee that it'll work.
Delaying for 2s should make this more reliable.It looks like there's a way do this reliably by waiting on a service to start, but I don't have an easy way to test it: https://powershellmagazine.com/2013/04/10/pstip-wait-for-a-service-to-reach-a-specified-status/ - it'd be worth following up on this in future.I gave the more correct method a go, and it seems to have worked!