refactor(bigquery)!: rename set_max_results to set_page_size - #6774
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the max_results field and its associated builder methods to page_size across the BigQuery crate, including examples, tests, and generated code configurations. This is driven by a new name override configuration in librarian.yaml. I have no feedback to provide.
alvarowolfx
marked this pull request as ready for review
September 10, 2026 15:33
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6774 +/- ##
=======================================
Coverage 97.02% 97.02%
=======================================
Files 326 326
Lines 107430 107430
=======================================
Hits 104238 104238
Misses 3192 3192 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alvarowolfx
marked this pull request as draft
September 10, 2026 16:02
alvarowolfx
marked this pull request as ready for review
September 11, 2026 22:16
dbolduc
approved these changes
Sep 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per API review discussion and also following what BigQuery did in their MCP server, we will rename max_results to page_size and later down the line introduce a setting to control size in bytes (relevant to Storage integration and arrow support)
Last breaking change before stable release.
Towards #5844