Skip to content

Make indentation consistent in pyguide.md#456

Open
funcodeio wants to merge 3 commits into
google:gh-pagesfrom
funcodeio:gh-pages
Open

Make indentation consistent in pyguide.md#456
funcodeio wants to merge 3 commits into
google:gh-pagesfrom
funcodeio:gh-pages

Conversation

@funcodeio

Copy link
Copy Markdown

No description provided.

@funcodeio

Copy link
Copy Markdown
Author

Since the guide's indentation is 4, it is good to have 4-space indentation in all examples through out the document. There were 2-space examples which made me confused.

@gpshead gpshead self-assigned this Jun 10, 2019
@gpshead

gpshead commented Jun 10, 2019

Copy link
Copy Markdown
Contributor

Thanks. Agreed this looks odd to people.

For what it's worth, the reason our guide is a bit messy this way is that we use two space indentation for our internal style but don't recommend that to the rest of the world which standardizes on four. We currently do not have an appropriate transformation setup to fix all of this in the examples as we publish the external version of the guide from our internal master.

I'm leaving this PR open assigned to me to deal with that one way or another.

@vapier vapier added lang:python The Python language and removed cla: yes labels Jul 8, 2024
@vapier

vapier commented Feb 21, 2025

Copy link
Copy Markdown
Member

so your point is def correct that the examples should be using 4 spaces. i think it might be a pain for us to handle internally though :(. we have an internal guide that we sanitize to produce the public guide.

@vapier

vapier commented Feb 21, 2025

Copy link
Copy Markdown
Member

ah, it looks like we do exactly that internally in some examples :(. we duplicate some code examples between internal (2 space) and external (4 space), but we didn't do it for all of them. oof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang:python The Python language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants