Update Capture Button visuals - #461
Conversation
f12a849 to
d9398ce
Compare
|
/gemini summary |
There was a problem hiding this comment.
Code Review
This pull request does a great job of updating the CaptureButton component's appearance and behavior. The changes align well with the design mocks, and the fixes for VIDEO_ONLY mode and volume button capture are significant improvements. The refactoring of the animation logic using updateTransition and the introduction of InteractionSource are excellent choices that follow Compose best practices. The simplification of the preview composables is also a welcome change that improves maintainability.
I've left a couple of comments: one to address a logic regression that could cause onRelease to be called twice, and another with a suggestion to simplify a boolean check for better readability. Overall, this is a high-quality contribution.
Summary of ChangesThis pull request refines the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
|
d9398ce to
647522b
Compare
Kimblebee
left a comment
There was a problem hiding this comment.
some duplicate comments regarding readibility, otherwise I think the PR looks great
5b07615 to
5a4ee7d
Compare
0c9b62a to
b471f94
Compare
50e48eb to
ff792fd
Compare
1cecafb to
b2369ba
Compare
321dcc2 to
89a21c5
Compare
89a21c5 to
d4b104e
Compare
This PR updates the appearance and behavior of the
CaptureButtoncomponent to better match design mocks and improve preview visibility.Key Changes
LocalShutterBackgroundStyle(WHITE_20andBLACK_60).Accessibility and Localization:
CaptureButtonfocusable and added appropriate roles and content descriptions.strings.xmlfor proper localization support.Refactoring and Testing:
CompositionLocalProvider(LocalInitialPressedState provides true), avoiding manual construction of complex UI states and ensuring accurate rendering in previews.CaptureButtonScreenshotTest.ktfor better maintainability.