Repository navigation
internal/export/idna: reject non-ASCII in xn-- labels - #73
Open
cristiangirlea wants to merge 1 commit into
Open
cristiangirlea wants to merge 1 commit into
cristiangirlea wants to merge 1 commit into
Conversation
decode copied the basic code points of a Punycode string without checking that they are ASCII, so a label such as "xn--が-" decoded to "が" and converted to the valid A-label "xn--v8j". RFC 3492 section 6.2 makes such input invalid, and UTS golang#46 processing step 4 records an error for an xn-- label that contains non-ASCII. Reject non-ASCII input in decode. The new tests fail before the fix. internal/export/idna passes on linux/amd64, including the UTS golang#46 conformance test with -long, and on linux/386 and with -race. With the change copied to x/net/idna, the example from the issue now returns an error. Fixes golang/go#81116
Contributor
|
This PR (HEAD: 807682b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/text/+/839845. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decode copied the basic code points of a Punycode string without
checking that they are ASCII, so a label such as "xn--が-" decoded to
"が" and converted to the valid A-label "xn--v8j". RFC 3492 section
6.2 makes such input invalid, and UTS #46 processing step 4 records
an error for an xn-- label that contains non-ASCII.
Reject non-ASCII input in decode.
The new tests fail before the fix. internal/export/idna passes on
linux/amd64, including the UTS #46 conformance test with -long, and
on linux/386 and with -race. With the change copied to x/net/idna,
the example from the issue now returns an error.
Fixes golang/go#81116