Repository navigation
Fix crash when opening ShaderEditorDock with a VisualShader open - #124245
Merged
Repiteo merged 1 commit intoOct 8, 2026
Merged
Conversation
kitbdev
reviewed
Oct 7, 2026
Contributor
There was a problem hiding this comment.
Fixes the crash.
But this causes it to get a focus outline when switching to it. I think the VisualShaderEditor shouldn't be taking focus here at all, so DocumentEditorContainer::focus_active_editor() should check if seb->get_base_editor() is null instead. Or check if its TextEditorBase instead of ScriptEditorBase.
If wanted, this can be merged as is to fix the crash, and the focus issue can be addressed after.
GabCoolDude
force-pushed
the
fix-shadereditor-visualshader-crash
branch
from
October 8, 2026 06:17
05122bc to
a6a521b
Compare
Contributor
Author
This is the approach I went ahead with, the focus outline was bugging me too. |
kitbdev
approved these changes
Oct 8, 2026
kitbdev
left a comment
kitbdev
left a comment
Contributor
There was a problem hiding this comment.
Looks good, fixes the issue.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?