Repository navigation
Add overlay to TileMapLayerEditor specifically for missing tile warning textures - #123779
Open
radioactivejackal1414 wants to merge 1 commit into
Open
radioactivejackal1414 wants to merge 1 commit into
radioactivejackal1414 wants to merge 1 commit into
Conversation
|
I just tested your solution and it works as expected, the split of custom_overlay control node into two specific nodes is, at least for me, the right move. However there are some issues I have:
Overall it looks fine to me, although I strongly suggest the renaming. |
radioactivejackal1414
force-pushed
the
tile-warning-textures
branch
2 times, most recently
from
September 29, 2026 23:30
108e83f to
d106459
Compare
Contributor
Author
|
Thanks for reviewing this @gabcont ! I've updated this based on your feedback:
Before: (TEXTURE_REPEAT_DISABLED) |
gabcont
reviewed
Sep 30, 2026
radioactivejackal1414
force-pushed
the
tile-warning-textures
branch
from
October 7, 2026 01:20
d106459 to
84f4506
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What problem(s) does this PR solve?
I added a new
Controlcalledtile_warning_overlaywhich is a child ofcustom_overlay, so that the warnings have their own overlay which is always set to a Linear filter.Additional information
Related: #123692