Repository navigation
Add missing AABB constructor with 6 real_t values - #2063
Merged
Merged
Conversation
aaronfranke
force-pushed
the
aabb-construct
branch
from
October 8, 2026 02:00
5a0626b to
60e16b4
Compare
Ivorforce
approved these changes
Oct 8, 2026
Ivorforce
left a comment
Ivorforce
left a comment
Member
There was a problem hiding this comment.
Corresponds to merged upstream pr
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as PR #1742, but for AABB instead of Projection.
When GDExtension generates bindings, it creates C++ code based on the API JSON. Values are serialized into literals constructed with numbers matching the value, for example,
Vector3(0, 1, 0). This includes default values for function parameters. AABB default values are serialized likeAABB(0, 0, 0, 1, 1, 1). However, Godot is missing a constructor for AABB, so the generated C++ code doesn't compile:I encountered this problem when the CI checks for godot-cpp failed to compile with my 4D module, because one of the bound methods includes an AABB default value, which cannot be constructed, as seen in the above image. This wasn't a problem in the engine before because the engine doesn't have any AABB default values in parameters.
See also PR which adds this to the engine: godotengine/godot#124240