Repository navigation
[WIP] Add documentation for the release cycle - #93
AThousandShips wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
@akien-mga Would appreciate some help on this section
There was a problem hiding this comment.
Rough process dump for editor strings: https://gist.github.com/akien-mga/9357c5886e06fdff70f0499970cd4115
I'll add the process for the docs/manual later.
There was a problem hiding this comment.
Transferred and integrated these steps partially and will do some proofreading of them tomorrow! Thank you!
There was a problem hiding this comment.
I updated the gist with a few fixes to the previous section, and a new section for the docs/manual update.
We'll go through that process together with @Calinou next week, so I suggest waiting for that so we can do further tweaks on the gist before integrating it in the contributing docs.
There was a problem hiding this comment.
Great! Then I'll take a look at a general new pass on this one when that's ready
There was a problem hiding this comment.
Do you have any updates on the translation process? Looking at potentially doing some work on this PR this week
There was a problem hiding this comment.
The gist linked above is complete. We ran through the docs process with @Calinou and I don't recall that it required further adjustments. So you can finish integrating it.
There was a problem hiding this comment.
Great! Then I'll look at that today and tomorrow
There was a problem hiding this comment.
@mhilbrunner @skyace65 Would appreciate some help outlining these processes here
There was a problem hiding this comment.
This is going to be a mhilbrunner thing. I haven't done release day changes (making the new branch) before.
There was a problem hiding this comment.
Hai. I can indeed provide at least some of these (especially the docs; translations are the big one where I lack the practical experience, although I've tried to follow along when Akien patiently explained the process to me :P)
I'm pretty swamped currently, but I'll try to find a minute to contribute in whatever form works best... maybe a PR to this PR?
Also thanks for taking the initiative and working on this, its been sorely needed for a long while.
There was a problem hiding this comment.
Thank you! And we can work out how to best provide the details, perhaps a gist? Or if someone else who is familiar with the details can help as well
But this PR will take a while to get through my own tuning and adding sections so no rush!
There was a problem hiding this comment.
@mhilbrunner are you able to look at some details for this? Trying to get some of the areas of this filled in
359938a to
4000c81
Compare
|
Updated from the outlines above, will look at adding the translation content next week and tuning some of the other sections, thank you @Repiteo! |
a7a0b58 to
0cb5fc9
Compare
|
CC @dsnopek @BastiaanOlij any steps critical for the extension/godot-cpp side that would be good to document here? |
It could make sense to add some notes to the
I think that's all that would fit in with what's in the PR so far. It may be worth nothing somewhere that we don't allow changes to |
|
Thank you will look at integrating that and doing some restructuring today! Edit: Will get back to this on Monday |
a89b7fc to
db55fb2
Compare
db55fb2 to
4000d29
Compare
|
Integrated the rest of the translation workflow with some adjustments will do a deeper proofread of it tomorrow and look at some of the other parts of the workflow |
e10e6ed to
f009483
Compare
|
Did some proofreading of the translation section and it should be good to go, will take a new pass over the rest of the changes next week and try to fill in the missing areas |
f009483 to
1329a78
Compare
|
|
||
| .. _doc_release_documentation_upgrading: | ||
|
|
||
| Upgrading from X to Y |
There was a problem hiding this comment.
@raulsntos could you assist in outlining this, perhaps we can create a template and some details on how this is tracked and organized, thanks!
There was a problem hiding this comment.
I usually copy the previous page and remove the contents of the "Breaking changes", "Behavior changes", and "Changed defaults" sections (I remove the tables but keep the intro text), to use it as a template.
To write the actual page contents, I look at various things:
- The GDExtension validation files in
misc/extension_api_validation.
Changes to property types are usually ignored, since they don't affect the scripting API surface, only the editor. The actual property type is the type used by the getter/setter methods. - The documentation files in
doc/classes.
Mostly to look for changed defaults. - The C# compatibility suppressions generated by the ApiCompat tool.
This requires making changes1 to the.csprojfiles and then building the engine and C# assemblies.
Often these changes match the ones in the GDExtension validation files, but it should be a smaller subset since API with compat methods would not be listed.
Sometimes it may highlight breaking changes exclusive to C#, like changes to type metadata (e.g. int32 -> int64), that are not usually considered breaking changes for GDExtensions.
Looking through those files, I collect the changes and then I find the PRs that introduced them. The GDExtension validation files already list the PR number, but for changes to the documentation files I have to use git blame to find the PR.
Then, I look through those PRs to try and understand what the changes are about, and whether the breaking changes can be avoided. In some cases, I may ask the team that owns the code for additional details.
Finally, I make the table with the changes and fill the columns. In some cases, I may create a Godot project to verify that the column values are correct.
The table categories and their order is mostly arbitrary and based on feels, but I do usually look at previous pages to try and keep it somewhat consistent. The contents within the tables are sorted alphabetically.
It may be worth noting that, in the past, I've usually waited until the RC before writing the migration page, because breaking changes keep being made up until (and sometimes after) the RC phase.
I also rely heavily on area maintainers to review the changes listed, and specially to fill the "Behavior changes" section which I have no way of collecting.
Let me know if this was useful or if you wanted something else.
Footnotes
There was a problem hiding this comment.
Thank you! I'll take a closer look next week and see about writing something from it and I'll ping you again if I have any further questions
There was a problem hiding this comment.
Updated with an outline based on this and will do a second pass over it next week
1329a78 to
c216b25
Compare
c216b25 to
dab4699
Compare
| .. note:: | ||
|
|
||
| This section is targeted at maintainers. For a general outline of the release | ||
| cycle, please see :ref:`doc_release_cycle_outline`. |
There was a problem hiding this comment.
Now in a separate PR:
Will leave it here for now and adjust depending on what merges first
Checklists for the release process
dab4699 to
5dbc2aa
Compare
Checklists for the release process
Still very much in progress but rough outlines for feedback and for the relevant teams to provide the steps for their areas