Repository navigation
Conversation
goelozev
approved these changes
Sep 11, 2026
leonard-tesnov
approved these changes
Sep 14, 2026
leonard-tesnov
left a comment
leonard-tesnov
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me. It fixes 2 vulns that were identified by the researchers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roleRefmutabilityPreviously,
DirectoryRoleBinding.spec.roleRefwas mutable, but not properly parsed on change. Thus, a change in roleRef would leave existing and new members ofDirectoryRoleBindingassigned to the previousroleRef.Changing the RoleRef of an existing
DirectoryRoleBindingwas not intended behavior, thus we resolve this by setting the field as immutable. This mirrors the behavior of native Kubernetes primitives such asClusterRoleBinding.RoleBindingownershipDRB reconciliation loop did not check controller ownership of a
RoleBinding, thus it could mutate aRoleBindingresource of the same name, even when the parentDirectoryRoleBindingwas not the owner of the resource. We now ensure ownership, and fail with "NotOwned" event if an existing resource was not created for this resource.Jira: FRI-22756