Repository navigation
Improve shared diagram rendering and honor authored styles - #1154
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model now draws the same flat, readable diagram in the editor, static page and exported SVG. Previously, duplicate renderer styles added shadows and mixed fonts, while standalone exports relied on fonts installed by the reader. Some existing author choices also disappeared: metadata/description visibility and icons were ignored, deployment-boundary defaults overrode explicit colors, and relationship labels dropped technology and ignored their configured wrapping width.
The shared renderer now uses one style definition, thinner borders and clearer defaults. It honors those existing style fields while preserving authored shapes, colors, dimensions and the existing layout rules. Relationship labels use the author's width and include technology when supplied. SVGs carry the same local Inter font faces used during measurement, together with their license, so they display consistently without a network connection. This adds roughly 136 KB to each SVG.
A browser regression serves a typed design through the real editor, exports it, and opens the file in a fresh browser. It checks actual icon decoding, standalone fonts and license, an explicitly sized Cylinder, hidden metadata/description, custom deployment-boundary colors, and 120px relationship wrapping. Existing text-fit, collision, component-boundary and manual-edit checks also pass. The basic and all-shapes examples were inspected before and after. Saved-coordinate and incremental-layout behavior are unchanged.