Repository navigation
Conversation
Editors retain their opening coordinates when the grid or page scrolls, leaving them detached from their cells. An editor can then appear to belong to a different row, making it unclear which record is being changed. Commit and close through the existing draft and validation handling to preserve the user's work when scrolling moves the cell. This deliberately ends the edit on scroll while allowing scrolling within the editor, its menus, or an unrelated grid. Related to glideapps#1159 and glideapps#1165.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editors retain their opening coordinates when the grid or page scrolls, leaving them detached from their cells. An editor can then appear to belong to a different row, making it unclear which record is being changed.
Commit and close the editor when the grid or a containing element scrolls, using the existing draft and validation handling to preserve the user's work. This deliberately ends the edit on scroll while allowing scrolling within the editor, its menus, or an unrelated grid. Related to #1159 and #1165.