Skip to content

ref(quart): Drop send_default_pii support - #7736

Merged
ericapisani merged 1 commit into
major/3.0from
py-2836-remove-send-default-pii-quart
Sep 29, 2026
Merged

ericapisani merged 1 commit into
major/3.0from
py-2836-remove-send-default-pii-quart

Conversation

@ericapisani

Copy link
Copy Markdown
Member

The data_collection option now fully governs user info, query string, and header capture in the Quart integration; send_default_pii is no longer consulted. Consolidates and dedupes the corresponding tests around data_collection cases.

Fixes PY-2836
Fixes #7607

The `data_collection` option now fully governs user info, query
string, and header capture in the Quart integration; `send_default_pii`
is no longer consulted. Consolidates and dedupes the corresponding
tests around `data_collection` cases.

Fixes PY-2836
Fixes #7607
@linear-code

linear-code Bot commented Sep 28, 2026

Copy link
Copy Markdown

PY-2836

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 62168 passed | ❌ 1 failed | ⏭️ 2906 skipped | Total: 65075 | Pass Rate: 95.53% | Execution Time: 177m 34s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -71784
Passed Tests 📉 -67522
Failed Tests 📈 +1
Skipped Tests 📉 -4263

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140595217997824

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:217: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140595217997824

✅ Patch coverage is 100.00%. Project has 2060 uncovered lines.
❌ Project coverage is 90.19%. Comparing base (21c9144) to head (43ebbd4).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.28%    90.19%    -0.09%
==========================================
  Files          195       179       -16
  Lines        26195     21003     -5192
  Branches      9758      7522     -2236
==========================================
+ Hits         23649     18943     -4706
- Misses        2546      2060      -486
- Partials      1483      1205      -278

Generated by Codecov Action

@ericapisani
ericapisani marked this pull request as ready for review September 28, 2026 18:24
@ericapisani
ericapisani requested a review from a team as a code owner September 28, 2026 18:24
@ericapisani
ericapisani merged commit 2749626 into major/3.0 Sep 29, 2026
416 of 423 checks passed
@ericapisani
ericapisani deleted the py-2836-remove-send-default-pii-quart branch September 29, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants