Skip to content

ref(huey): Drop send_default_pii support - #7728

Merged
pabloDeputter merged 1 commit into
major/3.0from
pablo/huey-drop-pii
Sep 28, 2026
Merged

pabloDeputter merged 1 commit into
major/3.0from
pablo/huey-drop-pii

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

Remove send_default_pii support from Huey integration.

Issues

Resolves #7594

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 62290 passed | ❌ 13 failed | ⏭️ 2890 skipped | Total: 65193 | Pass Rate: 95.55% | Execution Time: 169m 45s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -68295
Passed Tests 📉 -63978
Failed Tests 📉 -46
Skipped Tests 📉 -4271

➕ New Tests (13)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing
  • test_sets_new_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_uses_existing_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_sets_endpoint
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_none_falls_back_to_dsn
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_sets_new_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_uses_existing_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_sets_endpoint
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_none_falls_back_to_dsn
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_sets_new_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_uses_existing_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_sets_endpoint
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_none_falls_back_to_dsn
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing

➖ Removed Tests (59)

View removed tests
  • test_input_attributes_nonstreaming_chat[False-True-False-messages1-expected_system_instructions1-expected_input_messages1]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat[False-True-False-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat[False-True-False-messages3-expected_system_instructions3-expected_input_messages3]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat[False-False-True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat[False-False-True-messages1-expected_system_instructions1-expected_input_messages1]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat[False-False-True-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat[False-False-True-messages3-expected_system_instructions3-expected_input_messages3]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat[False-False-False-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat[False-False-False-messages1-expected_system_instructions1-expected_input_messages1]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat[False-False-False-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat[False-False-False-messages3-expected_system_instructions3-expected_input_messages3]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-True-True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-True-True-messages1-expected_system_instructions1-expected_input_messages1]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-True-True-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-True-True-messages3-expected_system_instructions3-expected_input_messages3]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-True-False-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-True-False-messages1-expected_system_instructions1-expected_input_messages1]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-True-False-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-True-False-messages3-expected_system_instructions3-expected_input_messages3]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-False-True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-False-True-messages1-expected_system_instructions1-expected_input_messages1]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-False-True-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-False-True-messages3-expected_system_instructions3-expected_input_messages3]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-False-False-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-False-False-messages1-expected_system_instructions1-expected_input_messages1]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-False-False-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[True-False-False-messages3-expected_system_instructions3-expected_input_messages3]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-True-True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-True-True-messages1-expected_system_instructions1-expected_input_messages1]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-True-True-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-True-True-messages3-expected_system_instructions3-expected_input_messages3]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-True-False-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-True-False-messages1-expected_system_instructions1-expected_input_messages1]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-True-False-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-True-False-messages3-expected_system_instructions3-expected_input_messages3]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-False-True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-False-True-messages1-expected_system_instructions1-expected_input_messages1]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-False-True-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-False-True-messages3-expected_system_instructions3-expected_input_messages3]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-False-False-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-False-False-messages1-expected_system_instructions1-expected_input_messages1]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-False-False-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral
  • test_input_attributes_nonstreaming_chat_async[False-False-False-messages3-expected_system_instructions3-expected_input_messages3]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat[True-True-True]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat[True-True-False]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat[True-False-True]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat[True-False-False]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat[False-True-True]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat[False-True-False]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat[False-False-True]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat[False-False-False]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat_async[True-True-True]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat_async[True-True-False]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat_async[True-False-True]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat_async[True-False-False]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat_async[False-True-True]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat_async[False-True-False]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat_async[False-False-True]
    • File: tests.integrations.mistral.test_mistral
  • test_output_attributes_nonstreaming_chat_async[False-False-False]
    • File: tests.integrations.mistral.test_mistral

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140306085773312

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140306085773312

test_sets_new_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_uses_existing_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_sets_endpoint

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_none_falls_back_to_dsn

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_sets_new_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_uses_existing_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_sets_endpoint

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_none_falls_back_to_dsn

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_sets_new_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_uses_existing_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_sets_endpoint

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_none_falls_back_to_dsn

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

✅ Patch coverage is 100.00%. Project has 2054 uncovered lines.
❌ Project coverage is 90.18%. Comparing base (609ccad) to head (97ffbef).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.22%    90.18%    -0.04%
==========================================
  Files          195       178       -17
  Lines        26101     20924     -5177
  Branches      9694      7502     -2192
==========================================
+ Hits         23548     18870     -4678
- Misses        2553      2054      -499
- Partials      1461      1188      -273

Generated by Codecov Action

@pabloDeputter
pabloDeputter marked this pull request as ready for review September 28, 2026 11:50
@pabloDeputter
pabloDeputter requested a review from a team as a code owner September 28, 2026 11:50
@pabloDeputter
pabloDeputter merged commit d7cdb32 into major/3.0 Sep 28, 2026
274 of 285 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/huey-drop-pii branch September 28, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants