Skip to content

ref: Unsample on sampler exception - #7723

Merged
sentrivana merged 5 commits into
masterfrom
ivana/unsample-on-sampler-exception
Sep 28, 2026
Merged

sentrivana merged 5 commits into
masterfrom
ivana/unsample-on-sampler-exception

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

As per https://github.com/getsentry/sentry-docs/pull/19189/changes, we should unsample the trace/profile if there's an exception in the user-provided traces_sampler or profiles_sampler.

Comment thread sentry_sdk/tracing.py
Comment thread sentry_sdk/profiler/transaction_profiler.py
Comment thread sentry_sdk/tracing_utils.py Outdated
@sentrivana sentrivana changed the title fix: Unsample on sampler exception ref: Unsample on sampler exception Sep 28, 2026
@sentrivana
sentrivana marked this pull request as ready for review September 28, 2026 09:24
@sentrivana
sentrivana requested a review from a team as a code owner September 28, 2026 09:24
@sentrivana
sentrivana enabled auto-merge (squash) September 28, 2026 09:30
@sentrivana
sentrivana merged commit bd08efd into master Sep 28, 2026
166 checks passed
@sentrivana
sentrivana deleted the ivana/unsample-on-sampler-exception branch September 28, 2026 09:37
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 129647 passed | ⏭️ 7152 skipped | Total: 136799 | Pass Rate: 94.77% | Execution Time: 440m 13s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -255
Passed Tests 📉 -255
Failed Tests —
Skipped Tests —

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2549 uncovered lines.
❌ Project coverage is 90.21%. Comparing base (ff7d0b2) to head (fc78d20).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.23%    90.21%    -0.02%
==========================================
  Files          194       194         —
  Lines        26030     26028        -2
  Branches      9678      9674        -4
==========================================
+ Hits         23487     23479        -8
- Misses        2543      2549        +6
- Partials      1454      1452        -2

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants