Skip to content

feat(typesafe): Record gen_ai.response.model #7717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 12 commits into from
Sep 28, 2026
Merged

feat(typesafe): Record gen_ai.response.model #7717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
97ecaa4
feat(typesafe): Add integration with system_one() patches
alexander-alderman-webb Sep 28, 2026
a5e7dfc
tests
alexander-alderman-webb Sep 28, 2026
0fdca7e
feat(typesafe): Record gen_ai.response.model
alexander-alderman-webb Sep 28, 2026
85cb1c4
.
alexander-alderman-webb Sep 28, 2026
8958cc7
.
alexander-alderman-webb Sep 28, 2026
245db24
Merge branch 'webb/typesafe' into webb/typesafe-response-model
alexander-alderman-webb Sep 28, 2026
b1766b9
.
alexander-alderman-webb Sep 28, 2026
3d4b797
Merge branch 'master' into webb/typesafe
alexander-alderman-webb Sep 28, 2026
1eb390d
Merge branch 'webb/typesafe' into webb/typesafe-response-model
alexander-alderman-webb Sep 28, 2026
1c87f8f
add minimum version
alexander-alderman-webb Sep 28, 2026
c0c5bf1
Merge branch 'webb/typesafe' into webb/typesafe-response-model
alexander-alderman-webb Sep 28, 2026
27987f9
merge master
alexander-alderman-webb Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions sentry_sdk/integrations/typesafe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
try:
from typesafe_sdk._core.client.aio.client import AsyncTypeSafeClient
from typesafe_sdk._core.client.sync.client import TypeSafeClient
from typesafe_sdk._core.response_types import SystemOneResponse
except ImportError:
raise DidNotEnable("typesafe-sdk not installed")

Expand Down Expand Up @@ -70,7 +71,14 @@ def wrap_system_one(self: "TypeSafeClient", *args: "Any", **kwargs: "Any") -> "A
if model is not None:
set_on_span(SPANDATA.GEN_AI_REQUEST_MODEL, model)

return f(self, *args, **kwargs)
response = f(self, *args, **kwargs)

if not isinstance(response, SystemOneResponse):
return response

set_on_span(SPANDATA.GEN_AI_RESPONSE_MODEL, response.model)

return response

return wrap_system_one

Expand Down Expand Up @@ -118,6 +126,13 @@ async def wrap_system_one_async(
if model is not None:
set_on_span(SPANDATA.GEN_AI_REQUEST_MODEL, model)

return await f(self, *args, **kwargs)
response = await f(self, *args, **kwargs)

if not isinstance(response, SystemOneResponse):
return response

set_on_span(SPANDATA.GEN_AI_RESPONSE_MODEL, response.model)

return response

return wrap_system_one_async
8 changes: 8 additions & 0 deletions tests/integrations/typesafe/test_typesafe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ def test_system_one(
assert span["attributes"][SPANDATA.GEN_AI_PROVIDER_NAME] == "typesafe"
assert span["attributes"][SPANDATA.GEN_AI_OPERATION_NAME] == "evaluate"
assert span["attributes"][SPANDATA.GEN_AI_REQUEST_MODEL] == "jev-latest"

assert span["attributes"][SPANDATA.GEN_AI_RESPONSE_MODEL] == "jev-latest"
else:
items = capture_items("transaction")

Expand Down Expand Up @@ -159,6 +161,8 @@ def test_system_one(
assert span["data"][SPANDATA.GEN_AI_OPERATION_NAME] == "evaluate"
assert span["data"][SPANDATA.GEN_AI_REQUEST_MODEL] == "jev-latest"

assert span["data"][SPANDATA.GEN_AI_RESPONSE_MODEL] == "jev-latest"


@pytest.mark.asyncio
@pytest.mark.parametrize("span_streaming", [True, False])
Expand Down Expand Up @@ -228,6 +232,8 @@ async def test_system_one_async(
assert span["attributes"][SPANDATA.GEN_AI_PROVIDER_NAME] == "typesafe"
assert span["attributes"][SPANDATA.GEN_AI_OPERATION_NAME] == "evaluate"
assert span["attributes"][SPANDATA.GEN_AI_REQUEST_MODEL] == "jev-latest"

assert span["attributes"][SPANDATA.GEN_AI_RESPONSE_MODEL] == "jev-latest"
else:
items = capture_items("transaction")

Expand Down Expand Up @@ -272,3 +278,5 @@ async def test_system_one_async(
assert span["data"][SPANDATA.GEN_AI_PROVIDER_NAME] == "typesafe"
assert span["data"][SPANDATA.GEN_AI_OPERATION_NAME] == "evaluate"
assert span["data"][SPANDATA.GEN_AI_REQUEST_MODEL] == "jev-latest"

assert span["data"][SPANDATA.GEN_AI_RESPONSE_MODEL] == "jev-latest"
Loading