ref(tornado): Drop `send_default_pii` support by pabloDeputter · Pull Request #7705 · getsentry/sentry-python

pabloDeputter · 2026-09-24T13:23:36Z

Description

TornadoRequestExtractor inherits from RequestExtractor which still has some send_default_pii branching, but this will be fixed in Remove send_default_pii from wsgi #7616.

Issues

Resolves #7615

github-actions · 2026-09-24T13:31:25Z

Codecov Results 📊

📊 Comparison with Base Branch

Metric	Change
Total Tests	📉 -71866
Passed Tests	📉 -67617
Failed Tests	📈 +13
Skipped Tests	📉 -4262

➕ New Tests (13)

View new tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
- Status: ❌ Failing
test_sets_new_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_uses_existing_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_sets_endpoint
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_none_falls_back_to_dsn
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_sets_new_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_uses_existing_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_sets_endpoint
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_none_falls_back_to_dsn
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_sets_new_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_uses_existing_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_sets_endpoint
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_none_falls_back_to_dsn
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing

❌ Failed Tests

`test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]`

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140699735511488

Stack Trace

tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140699735511488

`test_sets_new_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_uses_existing_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_sets_endpoint`

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_none_falls_back_to_dsn`

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_sets_new_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_uses_existing_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_sets_endpoint`

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_none_falls_back_to_dsn`

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_sets_new_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_uses_existing_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_sets_endpoint`

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_none_falls_back_to_dsn`

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

✅ Patch coverage is 100.00%. Project has 2056 uncovered lines.
❌ Project coverage is 90.18%. Comparing base (5d125bf) to head (c4a7024).

Coverage diff

@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.23%    90.18%    -0.05%
==========================================
  Files          194       178       -16
  Lines        26030     20934     -5096
  Branches      9678      7508     -2170
==========================================
+ Hits         23487     18878     -4609
- Misses        2543      2056      -487
- Partials      1454      1189      -265

Generated by Codecov Action

sentrivana

LGTM, one optional improvement suggestion

sentrivana · 2026-09-24T14:23:21Z

    [
        pytest.param(
-            {"send_default_pii": True},
+            {"data_collection": {}},


Totally optional, but we could clean this up more now that it's not really init_kwargs anymore, but just the data_collection definition: you can remove the outer {"data_collection": } dict from the first param everywhere, and rename the param init_kwargs -> data_collection, and then just provide it in the sentry_init as data_collection=data_collection.

pabloDeputter changed the title ~~Pablo/tornado drop pii~~ ref(tornado): Drop send_default_pii support Sep 24, 2026

pabloDeputter marked this pull request as ready for review September 24, 2026 14:15

pabloDeputter requested a review from a team as a code owner September 24, 2026 14:15

sentrivana approved these changes Sep 24, 2026

View reviewed changes

sentrivana mentioned this pull request Sep 24, 2026

ref(sanic): Drop send_default_pii support #7703

Merged

pabloDeputter added 3 commits September 28, 2026 11:21

ref(tornado): Drop send_default_pii support

dffac97

tests

4246d78

tests(tornado): Flatten test cases

8f8edfe

pabloDeputter force-pushed the pablo/tornado-drop-pii branch from ce25a48 to 8f8edfe Compare September 28, 2026 09:33

lint

c4a7024

pabloDeputter merged commit 68fa9c2 into major/3.0 Sep 28, 2026
142 of 147 checks passed

pabloDeputter deleted the pablo/tornado-drop-pii branch September 28, 2026 09:44

Navigation Menu

ref(tornado): Drop `send_default_pii` support - #7705

ref(tornado): Drop `send_default_pii` support#7705
pabloDeputter merged 4 commits into
major/3.0from
pablo/tornado-drop-pii

pabloDeputter commented Sep 24, 2026

Uh oh!

github-actions Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

sentrivana left a comment

Uh oh!

sentrivana Sep 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pabloDeputter commented Sep 24, 2026

Description

Issues

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

📊 Comparison with Base Branch

➕ New Tests (13)

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

test_sets_new_tracer_provider_with_otlp_exporter

test_uses_existing_tracer_provider_with_otlp_exporter

test_collector_url_sets_endpoint

test_collector_url_none_falls_back_to_dsn

test_sets_new_tracer_provider_with_otlp_exporter

test_uses_existing_tracer_provider_with_otlp_exporter

test_collector_url_sets_endpoint

test_collector_url_none_falls_back_to_dsn

test_sets_new_tracer_provider_with_otlp_exporter

test_uses_existing_tracer_provider_with_otlp_exporter

test_collector_url_sets_endpoint

test_collector_url_none_falls_back_to_dsn

Uh oh!

sentrivana left a comment

Choose a reason for hiding this comment

Uh oh!

sentrivana Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Sep 24, 2026 •

edited

Loading

`test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]`

`test_sets_new_tracer_provider_with_otlp_exporter`

`test_uses_existing_tracer_provider_with_otlp_exporter`

`test_collector_url_sets_endpoint`

`test_collector_url_none_falls_back_to_dsn`

`test_sets_new_tracer_provider_with_otlp_exporter`

`test_uses_existing_tracer_provider_with_otlp_exporter`

`test_collector_url_sets_endpoint`

`test_collector_url_none_falls_back_to_dsn`

`test_sets_new_tracer_provider_with_otlp_exporter`

`test_uses_existing_tracer_provider_with_otlp_exporter`

`test_collector_url_sets_endpoint`

`test_collector_url_none_falls_back_to_dsn`