Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
| HTTP/1.1 204 No Content | ||
| Tus-Resumable: 1.0.0 | ||
| Upload-Offset: 53477376 | ||
| Upload-Metadata: sentry eyJhdHRhY2htZW50X3R5cGUiOiJldmVudC5hdHRhY2htZW50In0=" |
There was a problem hiding this comment.
@tobias-wilfert according to the tus spec:
If an upload contains additional metadata, responses to HEAD requests MUST include the Upload-Metadata header and its value as specified by the Client during the creation.
I would only do this if it is easy to obtain from objectstore though.
There was a problem hiding this comment.
I checked, just to be sure, and we don't actually currently store this anywhere :/
|
Please update the IS YOUR CHANGE URGENT? section of the PR description:
This information helps the Docs team prioritize your review. |
|
The plan checks that the new upload guide is reachable. Services: Mention PlanWhat changedReaders of the attachments spec now follow a link to a new resumable-upload guide for large files. RiskA broken page or a bad link returns 404 for the new guide. Intended effectThe new guide must load at
Regression watchA bad MDX page or a broken link 404s the attachments tree.
Not observableWhether SDK authors send the new protocol to ingest is not visible on this site. |
| ``` | ||
| HTTP/1.1 204 No Content | ||
| Tus-Resumable: 1.0.0 | ||
| Upload-Offset: 5695864832 |
There was a problem hiding this comment.
nit: Can we make this value equal to the X-Decoded-Content-Length: 1073741824 above so that it show s that the upload offset should match the declared length for the final upload?
tobias-wilfert
left a comment
There was a problem hiding this comment.
Other than the small nit looks good.
Updates the spec on how to upload large files via the
/uploadendpoint.Closes: INGEST-777