Repository navigation
docs(sdk): Remove global logs enablement from the spec - #19653
Merged
Merged
Conversation
Define logging through API usage and explicit integration opt-in instead of a global enablement option. Bump the spec to 3.0.0 for the changed requirements. Fixes SDK-1534 Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Remove redundant opt-in text and distinguish dedicated disable-all APIs from general-purpose filtering callbacks. Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
szokeasaurusrex
approved these changes
Sep 28, 2026
szokeasaurusrex
marked this pull request as ready for review
September 28, 2026 09:35
szokeasaurusrex
enabled auto-merge (squash)
September 28, 2026 09:35
szokeasaurusrex
disabled auto-merge
September 28, 2026 09:35
1 task done
szokeasaurusrex
added a commit
that referenced
this pull request
Sep 28, 2026
## DESCRIBE YOUR PR Removes `enableMetrics` / `enable_metrics` from the Metrics spec's initialization options, processing pipeline, and automatic metrics rules. Preserves explicit integration opt-in and `beforeSendMetric` filtering. Uses the same target-state guidance as the Logs update in #19653: SDKs **SHOULD NOT** provide an API whose sole purpose is to disable all metrics. No SDK-specific deprecation timeline is added. Bumps the spec and the three affected sections to 3.0.0 for the changed requirements, preserving the historical changelog. Stacked on #19655, which separately removes obsolete experimental namespace guidance. Fixes [SDK-1535](https://linear.app/getsentry/issue/SDK-1535/remove-enablemetrics-from-the-develop-docs-metrics-spec). ## IS YOUR CHANGE URGENT? - [x] No deadline: Not urgent, can wait up to 1 week+ <!-- junior-request-attribution:start --> via **Daniel Szoke**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0C01CK9SG2%3A1790586263.068299 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AC0C01CK9SG2%3A1790586263.068299) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0C01CK9SG2%3A1790586263.068299/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
inventarSarah
pushed a commit
that referenced
this pull request
Sep 29, 2026
## DESCRIBE YOUR PR Removes `enableLogs` / `enable_logs` from the Logs spec's initialization options, processing pipeline, and integration requirements. Automatic log capture still requires explicit integration opt-in. SDKs **SHOULD NOT** provide APIs solely for disabling all logs; general-purpose filtering callbacks may still drop all logs. This describes the target contract rather than prescribing SDK-specific deprecation timelines. The historical changelog stays intact. Bumps the spec and affected sections to 3.0.0 because the existing requirements change incompatibly. Per the [spec lifecycle](https://develop.sentry.dev/sdk/getting-started/standards/spec-lifecycle/#changelog-and-since-conventions), `since` tracks when a section's current requirements were introduced, not its first stabilization. Fixes [SDK-1534](https://linear.app/getsentry/issue/SDK-1534/remove-enablelogs-from-the-develop-docs-logs-spec). ## IS YOUR CHANGE URGENT? - [x] No deadline: Not urgent, can wait up to 1 week+ <!-- junior-request-attribution:start --> via **Daniel Szoke**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0C01CK9SG2%3A1790586263.068299 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AC0C01CK9SG2%3A1790586263.068299) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0C01CK9SG2%3A1790586263.068299/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
inventarSarah
pushed a commit
that referenced
this pull request
Sep 29, 2026
## DESCRIBE YOUR PR Removes `enableMetrics` / `enable_metrics` from the Metrics spec's initialization options, processing pipeline, and automatic metrics rules. Preserves explicit integration opt-in and `beforeSendMetric` filtering. Uses the same target-state guidance as the Logs update in #19653: SDKs **SHOULD NOT** provide an API whose sole purpose is to disable all metrics. No SDK-specific deprecation timeline is added. Bumps the spec and the three affected sections to 3.0.0 for the changed requirements, preserving the historical changelog. Stacked on #19655, which separately removes obsolete experimental namespace guidance. Fixes [SDK-1535](https://linear.app/getsentry/issue/SDK-1535/remove-enablemetrics-from-the-develop-docs-metrics-spec). ## IS YOUR CHANGE URGENT? - [x] No deadline: Not urgent, can wait up to 1 week+ <!-- junior-request-attribution:start --> via **Daniel Szoke**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0C01CK9SG2%3A1790586263.068299 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AC0C01CK9SG2%3A1790586263.068299) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0C01CK9SG2%3A1790586263.068299/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Removes
enableLogs/enable_logsfrom the Logs spec's initialization options, processing pipeline, and integration requirements. Automatic log capture still requires explicit integration opt-in. SDKs SHOULD NOT provide APIs solely for disabling all logs; general-purpose filtering callbacks may still drop all logs.This describes the target contract rather than prescribing SDK-specific deprecation timelines. The historical changelog stays intact. Bumps the spec and affected sections to 3.0.0 because the existing requirements change incompatibly. Per the spec lifecycle,
sincetracks when a section's current requirements were introduced, not its first stabilization.Fixes SDK-1534.
IS YOUR CHANGE URGENT?
via Daniel Szoke.
--
View Junior Session [Sentry]