Skip to content

fix(develop): Fix ignore_spans example - #17846

Merged
sentrivana merged 2 commits into
masterfrom
ivana/fix-ignore-spans
May 22, 2026
Merged

sentrivana merged 2 commits into
masterfrom
ivana/fix-ignore-spans

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

ignore_spans is evaluated at span start, so it can't use status codes to make a decision.

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

`ignore_spans` is evaluated at span start, so it can't use status codes to make a decision.
@vercel

vercel Bot commented May 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment May 21, 2026 2:03pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
sentry-docs Ignored Ignored Preview May 21, 2026 2:03pm

Request Review

@github-actions github-actions Bot added the sdk-develop-docs PRs touching develop-docs/sdk label May 21, 2026
@sentrivana
sentrivana marked this pull request as ready for review May 21, 2026 13:58
@sentrivana
sentrivana enabled auto-merge (squash) May 21, 2026 14:13
@sentrivana
sentrivana requested a review from Lms24 May 22, 2026 07:36

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! really good catch!

@sentrivana
sentrivana merged commit 9841e87 into master May 22, 2026
19 of 20 checks passed
@sentrivana
sentrivana deleted the ivana/fix-ignore-spans branch May 22, 2026 12:05

This branch was successfully deployed

1 active deployment
Preview – develop-docs — 1582ddcb Deployed May 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk-develop-docs PRs touching develop-docs/sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants