Adjust form-action of Backend CSP - #2197
Merged
Merged
Conversation
Member
Author
We're basically reverting the CSP's enforcement of form submission behavior to what it was a couple of releases ago, before the CSP enforced it as strictly. |
lognaturel
approved these changes
Sep 4, 2026
lognaturel
left a comment
lognaturel
left a comment
Member
There was a problem hiding this comment.
I've reviewed the thread and agree this is a good temporary fix.
If I understand correctly, in the next release we will:
- have frontend go back to /blank.html as soon as it's retrieved the Backend response from document.body. (#2080 (comment))
- revert this change
- add e2e testing about the download of encrypted submission data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the latest aspect of #2080.
What has been done to verify that this works as intended?
Nothing much yet. It's not an error for me locally, since I don't believe the development nginx enforces a CSP. I updated a test of the CSP. I'm planning to try the repro steps again on staging once this PR is merged.
Why is this the best possible solution? Were any other approaches considered?
I've added thoughts about this approach at #2080 (comment). Ultimately, I would prefer to adjust the implementation in Frontend; I can file an issue about that. However, that'll be a little harder than the one-line change here. I don't think it's important enough to spend additional cycles on it before regression testing.
How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
Users can start submitting HTML forms from their Backend endpoints like we are? Hopefully users don't need to take such an approach. 馃槄