Upgrade Enketo to 7.6.4 - #2167
Merged
Merged
Conversation
Member
Author
|
Added @sadiqkhoja in case @alxndrsn doesn't have a chance to review. Would be great to get this on staging asap. |
Contributor
|
Useful comparisons:
git diff 7.6.1 7.6.4
git log 7.6.1..7.6.4 |
This was
linked to
issues
Sep 3, 2026
sadiqkhoja
approved these changes
Sep 3, 2026
Contributor
|
Discussed in the meeting to merge this and get this to staging so that this can be test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1885 Closes #2071
Because the Enketo default map config does not set
referrerPolicy, we need to add a map config block.What has been done to verify that this works as intended?
Upgraded to 7.6.4 on dev. Verified that Google Maps works. Verified that OSM with explicit referrerPolicy configuration works.
While doing this I noticed that OSM tiles don't work with an /x/ "offlineable" form. I see a
NS_ERROR_INTERCEPTION_FAILEDerror. This happens with 7.6.1 as well so I don't think we need to do anything about it. Cloud is unaffected because it uses Google Maps.Why is this the best possible solution? Were any other approaches considered?
I considered seeing whether we should add
referrerPolicyto the default Enketo maps config but I think this is ok.How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
I looked at the Enketo release notes and associated code changes and I think they're overall low-risk. The dynamic read-only doesn't appear to be complete (e.g. dates don't become read-only) but that's no worse than it was before.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No. Enketo docs have been updated for self-hosters who manage their own config.