Upgraded node to 24.20

[sadiqkhoja]

Partially closes getodk/central#2212

Sibling PR: getodk/central-backend#1936

[changeset-bot]

⚠️ No Changeset found

Latest commit: c40c339

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[matthew-white]

Do we definitely want to bump the required Node version for Web Forms with each release? I don't remember what the policy is. @garethbowen, would you mind taking a look?

[garethbowen]

For the npm packages, if anyone else is using them, it would be very annoying to bump the version every time. And if we leave the "engines" version at 24.16 then I think we need to leave the CI at 24.16 to ensure we don't break anything.

The intention was to use the node matrix when 26 goes LTS next month so we would test 24.16 and 26.x.

It's fine to bump the volta version to be consistent with frontend so dev uses 20.20.

[matthew-white]

Is there a way to bump the top-level engines without bumping engines for the individual Web Forms packages? I.e., can we bump engines for Central Frontend and the forms app without bumping engines for the individual packages?

I feel like it's a valuable verification step to check that Central Frontend CI runs successfully under the version of Node that we're actually deploying in production.

Or will that level of verification be achieved once we move to the node matrix?

[garethbowen]

Never mind! I just met with the brains trust and we decided WF will align with the central process for node versions, until someone who is actually using the npm packages starts complaining.

[garethbowen]

Thanks. I don't know if the WF policy is documented anywhere (will discuss in the next team meeting) but added a comment with my understanding.

[garethbowen]

For the npm packages, if anyone else is using them, it would be very annoying to bump the version every time. And if we leave the "engines" version at 24.16 then I think we need to leave the CI at 24.16 to ensure we don't break anything.

The intention was to use the node matrix when 26 goes LTS next month so we would test 24.16 and 26.x.

It's fine to bump the volta version to be consistent with frontend so dev uses 20.20.

[matthew-white]

I'm going to go ahead and merge this just to make sure there's no conflict with #1899.

[matthew-white]

I feel like @garethbowen's checkmark is sufficient to merge in terms of code review.

[matthew-white]

I see that there was some issue with required checks not starting. Is it because the checks reference the old Node version 24.16.0? E.g., "Test web-forms e2e / Functional e2e (24.16.0, chromium)". Maybe we need to update the list of required checks. 🤔

[sadiqkhoja]

yup that's the reason. I thought it was github's glitch. For now I have removed Test web-forms e2e / Functional e2e (24.16.0 * from the required checks.

I wonder if we should remove the node version number from the action name.