Remove skipAutoLogout route meta field - #1890
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
sadiqkhoja
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#2154.
What has been done to verify that this works as intended?
Tests continue to pass.
There was discussion on the issue that this mechanism is no longer needed.
Why is this the best possible solution? Were any other approaches considered?
I searched the codebase for
skipAutoLogoutand removed the associated code.If we ever need this mechanism again in the future, we can always add it back and revert this PR.
How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
I think the risk of regression is probably low given (1) the minimal code changes and (2) the fact that
skipAutoLogoutis no longer used. However, given the importance of the code in src/util/session.js, I'm thinking I probably won't merge this PR until after regression testing is complete. In other words, this PR is intended for v2026.4, not v2026.3.