chore: run e2e tests in Playwright container - #1888
Conversation
|
|
@garethbowen Last week, I had an issue with checks timing out because the browser download took too long, even though the tests weren't broken. I found in Playwright docs that they have containers. So far, it looks good to me. What do you think? |
garethbowen
left a comment
There was a problem hiding this comment.
Nice find!
To be confident of reliability changes like this we usually run the build multiple times (maybe 100). Have you tried that?
It looks like there are multiple threads here, not just the container change.
Does this also resolve getodk/central#2060 ? @alxndrsn
It might very well side-step it, but it doesn't seem to right now: https://github.com/getodk/central-frontend/actions/runs/34334779372/job/102523218655?pr=1888 |
What has been done to verify that this works as intended?
Run CI multiple times with different commits
Why is this the best possible solution? Were any other approaches considered?
Test web-forms e2e / Functional e2e (24.16.0, <browser>) are required status checks in branch protection, so after this merges, rebased and newly created branches will show them stuck at "Expected" and can't merge until our GH Admin updates the required check names. The same would happen anyway on any future node-version bump, so it's worth fixing the naming now.How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
N/A
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No