ci: output postgres logs - #1932
Merged
Merged
Conversation
Helpful for debugging workflow failures.
lognaturel
approved these changes
Sep 4, 2026
lognaturel
left a comment
lognaturel
left a comment
Member
There was a problem hiding this comment.
Consider adding || true so it doesn't look like it failed if previous steps failed.
1 task done
alxndrsn
added a commit
that referenced
this pull request
Sep 21, 2026
These jobs generate huge PostgreSQL logs, which add ~1 minute to build times. While these logs might be helpful occasionally, it's probably not worth the overhead to have them _always_ enabled. This impact was noted in #1944. Introduced in #1932, the original aim of that PR is still maintained, as PostgreSQL logs will still be available from other GitHub Actions workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helpful for debugging workflow failures.
What has been done to verify that this works as intended?
Used in #1924 to help debug intermittent postgres startup issues.
Why is this the best possible solution? Were any other approaches considered?
Not including these logs until they are needed? But in the case of #1924, there were occasional failures which could not be recreated easily on demand. This meant significant added time caused by configuring logs later, and then waiting for a failure to recur.
How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
No effect - just CI.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
No.