fix: decryptKeystore dead code, infinite recursion and wrong error classification#377
fix: decryptKeystore dead code, infinite recursion and wrong error classification#377ygd58 wants to merge 4 commits into
Conversation
…abs#305) The reset() method had dead code: - delete config[key] removed the key from the in-memory object - writeConfig(key, undefined) then wrote key=undefined back to disk Replace both lines with removeConfig(key) which correctly deletes the key and persists the change to disk. Fixes genlayerlabs#305
…rompt (genlayerlabs#306) Previously, passing an empty string to setNetwork() was treated as a valid network name due to the condition: if (networkName || networkName === "") This caused the command to search for a network named "" and always fail instead of falling through to the interactive prompt. Fix: simplify the condition to `if (networkName)` so empty strings are treated the same as undefined, correctly triggering the interactive network selection prompt. Fixes genlayerlabs#306
…erlabs#307) Two import statements were incorrectly placed in the middle of the file between the resolveNetwork() function and the BaseAction class definition: import { ethers } from 'ethers'; import { writeFileSync, existsSync, readFileSync } from 'fs'; Move them to the top of the file with all other imports. Fixes genlayerlabs#307
…assification (genlayerlabs#302) Three bugs fixed in BaseAction.decryptKeystore(): 1. Dead code: after failSpinner(process.exit), the recursive call was unreachable. Added explicit return after failSpinner. 2. Potential infinite recursion: if failSpinner did not exit, recursion continued without bound. Now returns empty string after max attempts to guarantee termination. 3. Wrong error classification: all errors from fromEncryptedJson were treated as wrong password. Now re-throws non-password errors (corrupted keystore, malformed JSON) immediately with a clear message. Fixes genlayerlabs#302
|
Warning Review limit reached
Next review available in: 38 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR targeted I retargeted it to |
1 participant
Summary
Fixes three bugs in
BaseAction.decryptKeystore().Bug 1: Dead Code
failSpinnercallsprocess.exit(1), making the recursive call on the next line unreachable. Added an explicitreturn ""afterfailSpinnerto make termination clear.Bug 2: Potential Infinite Recursion
If
failSpinnerwere ever called without exiting, the function would recurse indefinitely with no base case after the max-attempts branch. The explicitreturnnow guarantees termination.Bug 3: Wrong Error Classification
The
catchblock treated all errors fromfromEncryptedJsonas wrong-password errors, causing users with corrupted keystores to be prompted 3 times before seeing a misleading "Maximum attempts exceeded" message.Now re-throws non-password errors immediately with a descriptive message.
Fixes #302