fix: config reset no longer writes undefined value to disk#374
Conversation
…abs#305) The reset() method had dead code: - delete config[key] removed the key from the in-memory object - writeConfig(key, undefined) then wrote key=undefined back to disk Replace both lines with removeConfig(key) which correctly deletes the key and persists the change to disk. Fixes genlayerlabs#305
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR targeted I retargeted it to |
Summary
Fixes dead code in the
config resetcommand where the key was never actually removed from disk.Problem
The
reset()method had two bugs:delete config[key]— removes the key from the in-memory object onlywriteConfig(key, undefined)— immediately writeskey: undefinedback to disk, undoing the deletionAs a result,
genlayer config reset <key>appeared to succeed but the config file was unchanged.Fixes #305
Fix
Replace both lines with
this.removeConfig(key)which correctly deletes the key from the in-memory config object and persists the change to disk in a single operation.Changes
src/commands/config/getSetReset.ts: removed deaddelete config[key]line and replacedwriteConfig(key, undefined)withremoveConfig(key)