Fixed typing in 'import_classes_from_module' function - #48
Merged
Conversation
|
ab295382
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR fixes a typing error that occurs in the
import_classes_from_modulefunction on newer versions ofmypy:For some reason,
issubclasswas not type narrowing. I've rewritten the code slightly to drop a conditional in favour of an earliercontinuestatement. This also avoids a tiny bit of work for other classes.In additional, I dropped atry/exceptblock for aTypeErrorraised byissubclass. I assume this exists becauseissubclasswill raiseTypeErrorif not passed a class, but given we're runninginspect.isclassas a predicate above, I assume the only issue we could have here would be due to some particularly heinous metaprogramming, so I think it's fine!This has now been reverted, as it turns out the issue was due to Python 3.10.