Skip to content

fix: activate-only runs failed build-output validation - #86

Merged
frostebite merged 1 commit into
mainfrom
fix/skip-build-validation-for-activate-only
Aug 14, 2026
Merged

fix: activate-only runs failed build-output validation#86
frostebite merged 1 commit into
mainfrom
fix/skip-build-validation-for-activate-only

Conversation

@frostebite

Copy link
Copy Markdown
Member

Fifth bug in the same chain as #79/#81/#82/#84, found by re-running unity-activate#111's CI against v0.1.6.

The bug

Docker.run() unconditionally calls UnityBuildValidation.validateBuild(dockerRun.output) for the unity engine. That method requires a # Build results # section in the output — something only a real build ever produces — and throws There was an error building the project if it's missing.

Every activate-only run (activateOnly: true) hit this, right after activation itself genuinely succeeded:

Requesting activation (personal license)
Activation complete.
[ERROR] Error: There was an error building the project. Please read the logs for details.

There's nothing to validate — activate never builds anything.

The fix

Skip validateBuild when options.activateOnly is set.

How I found it

v0.1.6 (with #84) got unity-activate#111 past the last silent-failure bug (System.run swallowing a successful run). This is what showed up immediately after — activation itself worked, the CLI just failed it anyway afterward.

Testing

  • New tests in docker.test.ts: validateBuild is skipped for activateOnly: true, still runs for real builds.
  • bun run test — 153 pass, 3 skip, 0 fail.

🤖 Generated with Claude Code

Fifth bug in the unity-activate#111 chain. Docker.run() unconditionally
called UnityBuildValidation.validateBuild() for the unity engine, which
requires a "# Build results #" section - something only a real build ever
produces. Every successful activate-only run (activateOnly: true) threw
"There was an error building the project" right after "Activation
complete." printed, because there was never a build to validate.

Now skipped when activateOnly is set.
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d55966b2-4db6-429a-b040-14db38019ad5


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@frostebite
frostebite merged commit 66fe5cd into main Aug 14, 2026
15 checks passed
@frostebite
frostebite deleted the fix/skip-build-validation-for-activate-only branch August 14, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant