fix: disable enrolled-host discovery - #115
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 462971aab7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return ( | ||
| source.type === "local_path" && | ||
| source.projectId === project.id && | ||
| typeof source.hostId === "string" && | ||
| source.hostId !== primaryHostId |
There was a problem hiding this comment.
Keep malformed remote sources out of complete snapshots
When projects.list() returns a sole non-primary local_path source with malformed identity fields—for example, a missing id, unsafe updatedAt, or non-string path—this predicate still classifies it as an intentionally disabled remote project because it validates only type, project, and host. loadProjectInventory() consequently suppresses hasUnscannableProjects and reports a complete inventory; the controller treats that as permission to call refreshFromCompleteSnapshot, potentially retiring valid catalog targets. Only suppress foreign sources after validating their full non-local source shape; malformed declarations should continue to make the inventory partial.
Useful? React with 👍 / 👎.
462971a to
e38c7af
Compare
Context
Enrolled-host discovery is outside the current Plugin Studio scope. The existing primary-host scanner must remain authoritative without treating remote-only projects as an incomplete local inventory.
What changed
enrolledHostDiscoveryStudio feature flag, defaulting tofalseVerification
Boundary
No upstream bb work, browser behavior, package publication, or primary-host scanner changes. Refs #102.