Skip to content

fix: disable enrolled-host discovery - #115

Open
galligan wants to merge 1 commit into
mainfrom
fix/plugin-studio/disable-enrolled-host-discovery
Open

fix: disable enrolled-host discovery#115
galligan wants to merge 1 commit into
mainfrom
fix/plugin-studio/disable-enrolled-host-discovery

Conversation

@galligan

Copy link
Copy Markdown
Owner

Context

Enrolled-host discovery is outside the current Plugin Studio scope. The existing primary-host scanner must remain authoritative without treating remote-only projects as an incomplete local inventory.

What changed

  • adds one explicit enrolledHostDiscovery Studio feature flag, defaulting to false
  • omits remote-only projects while disabled so healthy primary-host inventory remains ready
  • keeps mixed, multiple, malformed, and ambiguous source declarations fail-closed and partial
  • retains the hard boundary that enrolled paths never enter filesystem discovery or public responses
  • reconciles the runtime ADR and convergence plan with the landed native stack and deferred Future: add bounded host-routed development-source discovery to bb #102 scope

Verification

  • focused Studio backend: 15 tests / 81 assertions
  • full workspace and scripts unit suites green
  • full check and bb 0.37 compatibility green
  • Studio build, Prettier, and diff checks green

Boundary

No upstream bb work, browser behavior, package publication, or primary-host scanner changes. Refs #102.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 462971aab7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +133 to +137
return (
source.type === "local_path" &&
source.projectId === project.id &&
typeof source.hostId === "string" &&
source.hostId !== primaryHostId

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep malformed remote sources out of complete snapshots

When projects.list() returns a sole non-primary local_path source with malformed identity fields—for example, a missing id, unsafe updatedAt, or non-string path—this predicate still classifies it as an intentionally disabled remote project because it validates only type, project, and host. loadProjectInventory() consequently suppresses hasUnscannableProjects and reports a complete inventory; the controller treats that as permission to call refreshFromCompleteSnapshot, potentially retiring valid catalog targets. Only suppress foreign sources after validating their full non-local source shape; malformed declarations should continue to make the inventory partial.

Useful? React with 👍 / 👎.

@galligan
galligan force-pushed the fix/plugin-studio/disable-enrolled-host-discovery branch from 462971a to e38c7af Compare August 13, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant