*Breaking change* Deprecate CurvedAnimation.reverseCurve in favor of AsymmetricCurvedAnimation#13347
Conversation
b0943d1 to
f17a81a
Compare
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 2321bc7): https://flutter-docs-prod--pr13347-breaking-changes-deprecate-ftgcwv6g.web.app |
|
@adil192, can we land this? If so, please remove from draft model. |
|
@sfshaza2 Don't we need to wait until flutter/flutter#185797 lands? @loic-sharma Do we have a deprecation window to put in the Timeline section? |
There was a problem hiding this comment.
Code Review
This pull request adds documentation for the deprecation of CurvedAnimation.reverseCurve in favor of AsymmetricCurvedAnimation and registers this new breaking change in the index. The review feedback focuses on correcting several API documentation link references where links meant for CurvedAnimation (such as reverseCurve and dispose) incorrectly point to AsymmetricCurvedAnimation. It also addresses a line length limit violation and suggests adding the missing reference link definitions.
|
Staged preview of the updated docs.flutter.dev site (updated for commit ce8adfe): https://flutter-docs-prod--docs-pr13347-breaking-changes-depre-s7gn3urm.web.app |
…f `AsymmetricCurvedAnimation`
…ed-animation-reverse-curve.md Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
ce8adfe to
56ebced
Compare
There was a problem hiding this comment.
Code Review
This pull request adds a new breaking change document detailing the deprecation of CurvedAnimation.reverseCurve in favor of AsymmetricCurvedAnimation, and updates the index page to link to it. The review feedback suggests wrapping a line in the markdown file that exceeds the 80-character limit, and correcting the alphabetical sorting of the new entry and its link definition in the index file.
|
Rebased and ready for review/merge along with flutter/flutter#185797 Edit: Marked as draft, see the link for details. |
Description of what this PR is changing or adding, and why:
Adds a migration guide for a breaking change in flutter/flutter#185797.
PRs or commits this PR depends on (if any):
CurvedAnimation.reverseCurveforAsymmetricCurvedAnimationflutter#185797Presubmit checklist
of 80 characters or fewer.