Skip to content

*Breaking change* Deprecate CurvedAnimation.reverseCurve in favor of AsymmetricCurvedAnimation#13347

Draft
adil192 wants to merge 6 commits into
flutter:mainfrom
adil192:breaking-changes/deprecate-curved-animation-reverse-curve
Draft

*Breaking change* Deprecate CurvedAnimation.reverseCurve in favor of AsymmetricCurvedAnimation#13347
adil192 wants to merge 6 commits into
flutter:mainfrom
adil192:breaking-changes/deprecate-curved-animation-reverse-curve

Conversation

@adil192

@adil192 adil192 commented May 3, 2026

Copy link
Copy Markdown

Description of what this PR is changing or adding, and why:

Adds a migration guide for a breaking change in flutter/flutter#185797.

PRs or commits this PR depends on (if any):

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@adil192 adil192 force-pushed the breaking-changes/deprecate-curved-animation-reverse-curve branch from b0943d1 to f17a81a Compare May 5, 2026 23:28
@loic-sharma loic-sharma self-requested a review May 5, 2026 23:42
@sfshaza2

sfshaza2 commented May 6, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

@flutter-website-bot

flutter-website-bot commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Visit the preview URL for this PR (updated for commit 2321bc7):

https://flutter-docs-prod--pr13347-breaking-changes-deprecate-ftgcwv6g.web.app

@sfshaza2

sfshaza2 commented May 7, 2026

Copy link
Copy Markdown
Contributor

@adil192, can we land this? If so, please remove from draft model.

@adil192

adil192 commented May 8, 2026

Copy link
Copy Markdown
Author

@sfshaza2 Don't we need to wait until flutter/flutter#185797 lands?

@loic-sharma Do we have a deprecation window to put in the Timeline section?

@adil192 adil192 marked this pull request as ready for review June 5, 2026 20:50
@adil192 adil192 requested review from a team and sfshaza2 as code owners June 5, 2026 20:50
@adil192 adil192 marked this pull request as draft June 5, 2026 20:50

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the deprecation of CurvedAnimation.reverseCurve in favor of AsymmetricCurvedAnimation and registers this new breaking change in the index. The review feedback focuses on correcting several API documentation link references where links meant for CurvedAnimation (such as reverseCurve and dispose) incorrectly point to AsymmetricCurvedAnimation. It also addresses a line length limit violation and suggests adding the missing reference link definitions.

@flutter-website-bot

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit ce8adfe):

https://flutter-docs-prod--docs-pr13347-breaking-changes-depre-s7gn3urm.web.app

@flutter flutter deleted a comment from flutter-website-bot Jun 5, 2026
adil192 and others added 4 commits June 29, 2026 20:57
…ed-animation-reverse-curve.md

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
@adil192 adil192 force-pushed the breaking-changes/deprecate-curved-animation-reverse-curve branch from ce8adfe to 56ebced Compare June 29, 2026 19:58
@adil192 adil192 marked this pull request as ready for review June 29, 2026 20:06

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new breaking change document detailing the deprecation of CurvedAnimation.reverseCurve in favor of AsymmetricCurvedAnimation, and updates the index page to link to it. The review feedback suggests wrapping a line in the markdown file that exceeds the 80-character limit, and correcting the alphabetical sorting of the new entry and its link definition in the index file.

Comment thread sites/docs/src/content/release/breaking-changes/index.md Outdated
Comment thread sites/docs/src/content/release/breaking-changes/index.md Outdated
@adil192

adil192 commented Jun 29, 2026

Copy link
Copy Markdown
Author

Rebased and ready for review/merge along with flutter/flutter#185797

Edit: Marked as draft, see the link for details.

@adil192 adil192 marked this pull request as draft June 29, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants