Packed basis matrices in LLL - #2827
Merged
Merged
Conversation
fredrik-johansson
force-pushed
the
gram
branch
from
September 6, 2026 15:28
15c2f04 to
1aa7c6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
fmpz_lllto use packedmpnrepresentation of basis matrices instead offmpz. Fixes #2389. For the multiprecision approximate LLL, few-limb dot products in the Gram basis are moreover done exactly via the dot product kernels introduced in #2824.This turned out to have a bigger impact than I anticipated; factoring S10 got 1.7x faster. Improved timings on the hard polynomials in
build/fmpz_poly_factor/profile/p-factor_hard -hard(the easier polynomials are unaffected):Implemented using Claude Fable 5.1.
Also fixes a bug in
fmpz_lll_heuristic_dot(apparently was harmless, but a bug nonetheless).