Repository navigation
fix: コメント間の区切り線をウィンドウ幅まで伸ばす - #231
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Closed
Co-authored-by: kyu08 <49891479+kyu08@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix comment delimiter extension to end of line
インラインコメントのdelimiterを行末まで延長
Oct 9, 2026
kyu08
reviewed
Oct 9, 2026
| local available_width = text_width - indent_width - right_margin | ||
| local box_width = math.min(max_box_width, math.max(50, available_width)) | ||
| local body_max_width = box_width - 6 | ||
| local border_width = math.max(2, text_width - indent_width) |
The request was about the separator between comments in the thread views, not the inline comment box borders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
コメントビューア、reply/editウィンドウ、コメントブラウザで、コメント間の区切り線（
---）が40文字固定で途中で切れていた。区切り線を表示しているウィンドウの幅まで伸ばす。before
after
変更内容
format_comments_for_display・format_reply_comments_for_display・format_comment_browser_threadに省略可能なseparator_width引数を追加し、区切り線をbuild_comment_separator(width)で生成するようにしたui/format.luaの純粋性（make check-purity）を保っているcalculate_float_dimensionsの幅を使う（style minimalのfloatなのでウィンドウ幅がそのままテキスト幅になる）nvim_win_get_widthを使う。エントリ切替のたびに再計算するので、リサイズ後も次の切替で追従するテスト計画
make all)tests/fude/ui_spec.lua:FudeReviewListCommentsで複数コメントのスレッドを開き、区切り線が右端まで伸びることを確認した備考
表示後にビューアやreply/editウィンドウをリサイズしても区切り線は再計算されない。
Generated with Claude Code