Repository navigation
fix: stop repeated messages accumulating spaces - #1266
Merged
Merged
Conversation
3r01
force-pushed
the
fix-repeated-message-spacing
branch
from
October 3, 2026 01:27
ab63e9d to
33e148a
Compare
3r01
force-pushed
the
fix-repeated-message-spacing
branch
from
October 4, 2026 22:29
33e148a to
f273384
Compare
Owner
|
Nice catch! Cycling through every gap shouldn't be necessary though, Twitch only compares against the previous message so alternating is enough (same as Chatterino). Maybe something like: val previousSentMessage = chatEventProcessor.getLastMessage(channel)
return when (previousSentMessage) {
trimmedMessage -> applyAntiDuplicate(trimmedMessage)
else -> trimmedMessage
} |
Contributor
Author
I wasn't sure if you wanted more variants of the duplicates (maybe for r9k mode, which does compare across the last 30 seconds iirc), which you get for free with this cycling, but it sounds like that isn't the intention so I will simplify. |
flex3r
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[...] replaced repeating
forsenE. The timeout was for message height in forsen’s chat, repeatedly sending the same message adds another space after the first word each time so the message gets progressively longer.This PR instead cycles one additional space through the gaps then loops back to the original:
Now it gains at most one extra space.
I'm not sure if the accumulating spaces were added for a specific reason but if so let me know and I'll try to cover that use case as well.